Montego Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic
Author Message
Palbin
Newbie
Newbie



Joined: Nov 26, 2007
Posts: 25

PostPosted: Tue Mar 22, 2011 7:26 pm Reply with quote

What is the purpose of the tnsl_fCleanLinks() function?
The reason I am asking is that I have gotten a report about it not playing nice with &'s in javascript that should not be converted to &. While looking to into this issue I found that there is an "exception" hard coded to allow the ajax validation in Your Account. I think that is impractical for outside developers. So I am looking for your input. I do not see the need for it, but thought I should come and ask just in case.
 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Wed Mar 23, 2011 2:22 pm Reply with quote

It is definitely needed as I cannot be guaranteed that module developers will all code their href's in a compliant manner so I have to "cleanse" them so that the patterns will match up.

I know someone here suggested some possible updates to the code, but when I looked at it, they took it too far in my opinion. Let me refresh my memory on that and get back to you.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Thu Mar 24, 2011 8:52 am Reply with quote

Sorry Palbin... didn't get to it last night or this morning. Hopefully tonight will be a better night.. <sigh>

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Killing-Hours
Newbie
Newbie



Joined: Mar 24, 2011
Posts: 10

PostPosted: Thu Mar 24, 2011 9:54 am Reply with quote

Montego-

Is there a way to retain the "original" link and output that if there isn't a match against shortlinks?
 
View user's profile Send private message
Palbin
Newbie
Newbie



Joined: Nov 26, 2007
Posts: 25

PostPosted: Sat Mar 26, 2011 1:22 pm Reply with quote

Montego, I know this is not the way anything is set up, but shouldn't the regular expressions in the tap files be compensating for this instead of doing a global replace?
 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Sun Mar 27, 2011 11:04 am Reply with quote

Palbin, if it can be done globally, for the right things, that would be better as folks already have issues with tapping links and I would hate to complicate it any further for them.

The thread with the ideas is here. But, I just haven't had time to dissect how to improve upon it. This code has issues, but I like the idea.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Display posts from previous:       
Post new topic   Reply to topic

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 4 Hours
 
Forums ©
linear-bunch