Montego Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic
Author Message
Guardian
Site Admin
Site Admin



Joined: Jul 18, 2005
Posts: 397

PostPosted: Tue Jun 09, 2009 11:18 am Reply with quote

Reference this thread;
http://www.ravenphpscripts.com/modules.php?name=Forums&file=viewtopic&p=137672

fkelly points out the following code in the newsletter send routine
Code:

if ( $msnl_iView == 1 ) {  //All registered users

         $sql = "SELECT `user_id`, `user_email` FROM `".$user_prefix."_users` WHERE `user_email` > ''";

In essence, this means that with the advent of RNYA, newsletters could be sent to 'suspended' users.

I believe RNYA has an is_active() function that could be used but it might be easier to do something like
Code:

if ( $msnl_iView == 1 ) {  //All registered users

if(defined('RN_CONSTANT_TEST')) {
$sql = "SELECT `user_id`, `user_email` FROM `".$user_prefix."_users` WHERE `user_email` AND `user_active`=1 > ''";
} else
{
$sql = "SELECT `user_id`, `user_email` FROM `".$user_prefix."_users` WHERE `user_email` > ''";
 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Tue Jun 09, 2009 3:45 pm Reply with quote

Amazing the tangled web that we weave. Good catch. I'll have to review this and post back with the actual fix as well as update the rps thread too.

Thanks!

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Display posts from previous:       
Post new topic   Reply to topic

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 4 Hours
 
Forums ©
linear-bunch
linear-bunch