Montego Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic
Author Message
Palbin
Newbie
Newbie



Joined: Nov 26, 2007
Posts: 25

PostPosted: Thu Feb 19, 2009 11:33 pm Reply with quote

Since you are going to be working on this again I would like to see nsngr_func.php moved from includes/nsngr_func.php to modules/downloads/includes/nsngr_func.php

Of course that is just my opinion Smile

I am not sure about this but if it is the same as NukeProject it includes nsngr_func.php in mainfile.php. This should only be loaded in the blocks and module if needed, not every time.
 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Fri Feb 20, 2009 8:01 am Reply with quote

I agree. A simple include_once() in the block (if needed) and the module should do the trick. I had just read your email from Mantis on the NukeProject side and it does make sense.

Thanks!

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Palbin
Newbie
Newbie



Joined: Nov 26, 2007
Posts: 25

PostPosted: Fri Feb 27, 2009 9:36 am Reply with quote

What do you think about also moving the language files into the module?
 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Fri Feb 27, 2009 10:39 am Reply with quote

BTW, since this is for NSN GR Downloads, I was thinking your original post was specific to that. Sorry, didn't look at the file name that closely... thought I saw nsngd. For the downloads module, they already are within the module.

The problem with NSN Groups, is that the administration side of things are for superusers and so things are split up a bit. But, I have no issues with moving from languages/nsngroups to /modules/Groups/languages as long as no-one else on the RN Team does. Probably a better discussion for Mantis or Raven's RN forums though.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Display posts from previous:       
Post new topic   Reply to topic

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 4 Hours
 
Forums ©
linear-bunch
linear-bunch