Montego Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic
Author Message
kguske
Community Giant



Joined: Dec 11, 2005
Posts: 32

PostPosted: Tue Apr 01, 2008 1:34 pm Reply with quote

Thought I would post this here since I found the issues with the Legal module for RN you worked on with DadaNuke.

First a couple of spelling corrections in the SQL file:

EDTIOR -> EDITOR
INDICENTAL - > INCIDENTAL

Next, since RN doesn't have a _cities table, attempts to update the Terms of Use content result in wiping out the default United States of America that is installed in the SQL. Further, there are no other choices in the list. Is the cities table something that's not included in the RN version of the download, or does the module assume this table exists (possibly from a post 7.6 version of Nuke)?

_________________
nukeSEO.com - PHPNuke SEO search engine optimization and other professional tools for PHP-Nuke 
View user's profile Send private message
Guardian
Site Admin
Site Admin



Joined: Jul 18, 2005
Posts: 397

PostPosted: Tue Apr 01, 2008 6:02 pm Reply with quote

Thats interesting.
Looks like the cities table was removed in 2.20.x. I remember some debate about it as it was only used by the Advertising module and seemed such a waste to have that huge table just to set one word which, might be why it was removed and just put in the Advertising blurb as editable plain text.
I'll have to remember this for when I eventually upgrade - thanks kguske!
 
View user's profile Send private message
kguske
Community Giant



Joined: Dec 11, 2005
Posts: 32

PostPosted: Tue Apr 01, 2008 6:10 pm Reply with quote

Yeah, I posted a message on DaDaNuke.org after I found the cities.sql in the 1.1 download of the Legal module.

_________________
nukeSEO.com - PHPNuke SEO search engine optimization and other professional tools for PHP-Nuke 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Wed Apr 02, 2008 5:25 pm Reply with quote

Yeah, I forgot about that too. I will correct it within the RN SVN this week. I'll change it to go against the NS tables.

We had left the nuke_cities table within RN for upgrade purposes (i.e., we did not delete it), but we did remove it from the core install for new installs.

What is your "take" on the difference in the names of the countries between nuke_cities and the NS country table? I am not sure about this now.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
kguske
Community Giant



Joined: Dec 11, 2005
Posts: 32

PostPosted: Wed Apr 02, 2008 7:36 pm Reply with quote

Haven't compared them. But I certainly like the idea of having a countries table (vs. getting unique countries from the cities tabe).

_________________
nukeSEO.com - PHPNuke SEO search engine optimization and other professional tools for PHP-Nuke 
View user's profile Send private message
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1399

PostPosted: Wed Apr 02, 2008 9:15 pm Reply with quote

That is a fine idea as well. Will keep that in mind sir.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Display posts from previous:       
Post new topic   Reply to topic

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 4 Hours
 
Forums ©
linear-bunch
linear-bunch