Problem with Dynamic Titles and News

Newbie Joined: Sep 11, 2006 Posts: 92

I noticed you forgot to include bodytext in the dynamic titles sql call. It creates a problem when users don't use any home text. Yeah I know thats rare as hell, but it does happen.

Old

Code:

// News
elseif ($name == 'News') {
global $file, $sid, $new_topic;
if ($new_topic != '') {
   $sql = 'SELECT topictext FROM '.$prefix.'_topics WHERE topicid=\''.intval($new_topic).'\'';
   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);
   $newpagetitle = $row['topictext'];
} elseif ($file == 'article') {
   $sql = 'SELECT title, topic, hometext FROM '.$prefix.'_stories WHERE sid=\''.intval($sid).'\'';
   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);
   $asDTText['subject'] = $row['title'];
   $asDTText['text'] = substr($row['hometext'], 0, $text_size);
   $sql = 'SELECT topictext FROM '.$prefix.'_topics WHERE topicid=\''.intval($row['topic']).'\'';
   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);
   $newpagetitle = $asDTText['subject'].$dt_delim.$asDTText['text'].$dt_delim.$row['topictext'];
}
}

New

Code:

// News
elseif ($name == 'News') {
global $file, $sid, $new_topic;
if ($new_topic != '') {
   $sql = 'SELECT topictext FROM '.$prefix.'_topics WHERE topicid=\''.intval($new_topic).'\'';
   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);
   $newpagetitle = $row['topictext'];
} elseif ($file == 'article') {
   $sql = 'SELECT title, topic, hometext, bodytext FROM '.$prefix.'_stories WHERE sid=\''.intval($sid).'\'';
   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);
   $asDTText['subject'] = $row['title'];
   $asDTText['text'] = substr($row['hometext'].$row['bodytext'], 0, $text_size);
   $sql = 'SELECT topictext FROM '.$prefix.'_topics WHERE topicid=\''.intval($row['topic']).'\'';
   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);
   $newpagetitle = $asDTText['subject'].$dt_delim.$asDTText['text'].$dt_delim.$row['topictext'];
}
}