| Author |
Message |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sat Feb 18, 2006 7:03 pm |
|
Hi montego...
The guy who i installed the newsletter for says the newsletter shows this as in the subject line..
Subject: Re: Newsletter from ;;
Any idea where the .... & n b s p ; comes from? |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1360
|
Posted:
Sat Feb 18, 2006 10:39 pm |
|
That is very strange. This works in IE and FF. What browser was he using at the time he submitted this. Also, I am wondering if the email client is adding this.
By the way, did you remove some of the subject line or is he really getting two spaces and then a semi-colon?
Also, this is a strange request, but try his Topic without any special characters (but a space should be fine). |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sat Feb 18, 2006 10:52 pm |
|
Hi,
Well your forum doesnt allow me to post this...& n b s p ; (without spaces between)
cause it will result in this > ;;
anyway thats what get added in the subject line...
this..Subject: Re: Newsletter from& n b s p ; (without spaces between)
ill read the reply in the morning,then ill try to figure out with him where this comes from...
he uses IE.
ill let you know..  |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1360
|
Posted:
Sat Feb 18, 2006 11:33 pm |
|
Oh, I think I know what it is now. Is his "Site Name:" set up in the Preferences? It looks to me like it is blank.
Sorry, wasn't thinking earlier. Been kind of queezy all day. |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sun Feb 19, 2006 10:08 am |
|
its not the site name montego,he has that filled ...
he told he uses outlook.
so for some weird reason the space in the subjectline is converted into...
& n b s p ; (without spaces between)
could it be in the part where the mailheaders are created? |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1360
|
Posted:
Sun Feb 19, 2006 10:33 am |
|
Ok. Definitely odd. I need to rule out something. I need to see his saved newsletter file. You can find the right one by going to *Maintain Newsletters* and editing the right newsletter. In there you will see the newsletter file name (a number plus the .php extension on it).
Either email it to me or write back exact what is shown at the top for the $ftopic variable.
Thanks!
BTW, I will be leaving here shortly and gone for the entire day, so you won't hear back from me until later tonight or tomorrow morning latest. |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sun Feb 19, 2006 10:47 am |
|
| Code: |
if (!defined('MSNL_LOADED')){die("Cannot Access Newsletter Directly");}
$ftopic = "hitwalker test";
$fsender = "shark";
$fcid = "1";
$emailfile = <<< EOD
<!-- Hi mav2 Your System cannot read HTML-Mails! Following message was send to you: test -->
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
|
thats the top montego.,. |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1360
|
Posted:
Sun Feb 19, 2006 11:04 am |
|
uggghhh.. I am such a dope sometimes! Sorry hitwalker. The issue is somehow with the $sitename variable which is replacing the {SITENAME} tag in the template. If your friend has the site name populated in the preferences, then I cannot see how you are not getting that text in the "Subject" line.
Are you able to post here what exactly is in his/her site name field?
By the way, I am not apposed to taking a look at it myself if you wish to not be the intermediary. We might be able to solve this quicker. If you agree, PM me the web address, temporary admin userid/password (make sure NS has me as protected!, and either cpanel id/password or an FTP userid/password so I can check the files too.
Be back later tonight. |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
Guardian
Site Admin


Joined: Jul 18, 2005
Posts: 387
|
Posted:
Sun Feb 19, 2006 7:07 pm |
|
I think we discussed this via PM some time ago when we were testing 1.3 before the editor integration but I thought it was an Outlook mail client issue. |
| |
|
|
 |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sun Feb 19, 2006 7:25 pm |
|
well we cant find any solution,maybe its outlook i dont know but it shouldnt happen...  |
| |
|
|
 |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sun Feb 19, 2006 7:47 pm |
|
well hi did....found something weird..
The system uses the same template on test mail and normal mail right?
well...when he uses testmail then all sows okay...
and with normal mail then it goes wrong.. |
| |
|
|
 |
Guardian
Site Admin


Joined: Jul 18, 2005
Posts: 387
|
Posted:
Sun Feb 19, 2006 7:50 pm |
|
I think the test mails are created during the table installation, if you check the date on those they are a couple of years old but it is interesting and might lead to solving the problem as obviously something has changed from V1.2 to 1.3 which causes this.
I may do a file compare later. |
| |
|
|
 |
hitwalker
Newbie


Joined: Nov 06, 2005
Posts: 25
|
Posted:
Sun Feb 19, 2006 8:20 pm |
|
Well we came up with another solution...
On line 567 HTML_Newsletter/admin/functions.php
we change line from this $emailtitle = _MSNL_ADM_SEND_LAB_NLFROM." ".$sitename;
change line from this
$emailtitle = _MSNL_ADM_SEND_LAB_NLFROM." ".$sitename;
to this
$emailtitle = _MSNL_ADM_SEND_LAB_NLFROM." ".$sitename;
That solved his problem...BUT..
He found another problem or bug..
He was sending out mails as a test and a member noticed this:
| Code: |
<!-- Hi jesse Your System cannot read HTML-Mails! Following message was send
to you: test --> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01
Transitional//EN">
|
So..."jesse is the username right?
In case he cant read html mails...?
Funny thing is ,the username wasnt jesse..  |
| |
|
|
 |
Guardian
Site Admin


Joined: Jul 18, 2005
Posts: 387
|
Posted:
Sun Feb 19, 2006 8:28 pm |
|
I think the name is hard coded but I have been unable to find my old copies of HNL 1.2 so am unable to run a compare.
It seems that it is also enclosed within html comment tags.
I think the idea there (for future use) was to encapsulate the username and possibly the newsletters file name/id within html comment tags so, when the newsletter is viewed as html it is not seen but if the mail client is text only, he would see the commented out text and be able to click the link. |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1360
|
Posted:
Sun Feb 19, 2006 11:41 pm |
|
Ok, guys, I am back now. And I have answers.
| Quote: |
$emailtitle = _MSNL_ADM_SEND_LAB_NLFROM."& n b s p ;".$sitename;
to this
$emailtitle = _MSNL_ADM_SEND_LAB_NLFROM." ".$sitename; |
Yeah, it looks like I missed changing it in this one place. Surprising that I did not catch this in my several sends to NSN Groups... Sorry about that. Good job, though, in finding the problem and the fix.
| Quote: |
So..."jesse is the username right?
In case he cant read html mails...? |
This one is a known bug (by me). The code is taking the Last Forum poster as the name. Since this was only going to be seen on non-HTML web clients (which defeat the purpose of having an HTML Newsletter to begin with), I did not see it as "high priority". It will be fixed in 1.4 if not sooner. I really wanted to wait to change the tool to allow for better personalization, but that was beyond the scope of 1.3.
| Quote: |
| I think the test mails are created during the table installation, if you check the date on those they are a couple of years old but it is interesting and might lead to solving the problem as obviously something has changed from V1.2 to 1.3 which causes this. |
This one came from Guardian. Newsletter ID 1 is used for the Preview newsletters and Newsletter ID 2 is for the testemail (to admin). These are system-level / defined newsletters and they are overwritten as you do previews and eventually do your final send. You do not need to worry about these at all. They take care of themselves, but, as admin, you can still see them and view them depending on where in the newsletter creation cycle you are in. Again, don't worry about them.
Regards,
montego |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
|
|