Montego Scripts: Forums
 

 

View next topic
View previous topic
Post new topic   Reply to topic
Author Message
Susann
Newbie
Newbie



Joined: Jan 04, 2007
Posts: 61
Location: Germany

PostPosted: Fri Oct 12, 2007 1:33 pm Reply with quote

I found a problem with the e-mail adress within the messages from NSN GR Downloads.
Not sure if this is a bug or its my system but the e-mail address "from" doesn´t look right.Rolling Eyes
So quick question.
After a download is submitted there are 2 e-mail notifications.
Your submitted download has been approved! etc.

In wich file can I change in this e-mail my address ?
 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1393

PostPosted: Fri Oct 12, 2007 10:07 pm Reply with quote

I'll have to get back to you on this one. I am not feeling so well and need to head to bed... Sad

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Susann
Newbie
Newbie



Joined: Jan 04, 2007
Posts: 61
Location: Germany

PostPosted: Sat Oct 13, 2007 6:54 am Reply with quote

Get well soon! Maybe I can find out more about the e-mail issue this weekend.
 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1393

PostPosted: Sat Oct 13, 2007 10:04 am Reply with quote

Susann,
For Submit Downloads, the file is this one:

modules/Submit_Downloads/index.php

For the admin approving a new download, the mail is sent from here:

modules\Downloads\admin\DownloadAddSave.php

In each case, search for "mail(" and you will find where you need to make changes if you feel that you need to.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Susann
Newbie
Newbie



Joined: Jan 04, 2007
Posts: 61
Location: Germany

PostPosted: Sun Oct 14, 2007 6:59 pm Reply with quote

Thanks. I was able to change the e-mail in index.php.
But the importent changes in modules\Downloads\admin\DownloadAddSave.php
didn´t worked.
Montego how do I change my e-mail adress there ?
I don´t like the way its designed. The messages have the hostname as from in it and thats not the complete issue.
Btw: I added a download to your section to check how you e-mail looks like. Smile

Thats the part in DownloadAddSave.php :

Code:
$from = "$sitename";
      @mail($email, $subject, $message, "From: $from\nX-Mailer: PHP/" . phpversion());
    }
 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1393

PostPosted: Mon Oct 15, 2007 8:08 am Reply with quote

Ok, yeah, that is pretty ugly. Sad Maybe this will get you by for now:

=== FIND CODE ===

Code:

    if ($email!="") {
      $subject = ""._YOURDOWNLOADAT." $sitename";
      $message = ""._HELLO." $sname:\n\n"._DL_APPROVEDMSG."\n\n"._TITLE.": $title\n"._URL.": $url\n"._DESCRIPTION.": $description\n\n\n"._YOUCANBROWSEUS." $nukeurl/modules.php?name=$module_name\n\n"._THANKS4YOURSUBMISSION."\n\n$sitename "._TEAM."";
      $from = "$sitename";
      @mail($email, $subject, $message, "From: $from\nX-Mailer: PHP/" . phpversion());
    }


=== REPLACE WITH ===

Code:

    if ($email!="") {
      $subject = ""._YOURDOWNLOADAT." $sitename";
      $message = ""._HELLO." $sname:\n\n"._DL_APPROVEDMSG."\n\n"._TITLE.": $title\n"._URL.": $url\n"._DESCRIPTION.": $description\n\n\n"._YOUCANBROWSEUS." $nukeurl/modules.php?name=$module_name\n\n"._THANKS4YOURSUBMISSION."\n\n$sitename "._TEAM."";
      $mailheaders = "From: $adminmail\r\n";
      $mailheaders .= "Reply-To: $adminmail\r\n";
      $mailheaders .= "X-Mailer: NSNGD\r\n";
      @mail($email, $subject, $message, $mailheaders);
    }


That might get you closer.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Susann
Newbie
Newbie



Joined: Jan 04, 2007
Posts: 61
Location: Germany

PostPosted: Mon Oct 15, 2007 9:43 am Reply with quote

Great Montego this is solved !!!
Thank you so much !
I´m so glad that I got rid of these strange e-mail adresses. Smile
 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1393

PostPosted: Mon Oct 15, 2007 9:54 am Reply with quote

You are welcome. I, of course, when I get to it, incorporate these changes into a 1.1.0 release.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1393

PostPosted: Mon Feb 21, 2011 10:20 am Reply with quote

Fixed in 1.1.0 currently in development when I added TegoNuke(tm) Mailer integration.
 
View user's profile Send private message Visit poster's website
hicux
Newbie
Newbie



Joined: Jan 30, 2009
Posts: 90
Location: NL

PostPosted: Wed Feb 23, 2011 7:22 pm Reply with quote

Montego, when I see you working on this module step by step trying to make it perfect, secure and smooth I do not want to get rid of phpnuke but why it took so much time to make a more efficient download module who really does all like the one I had for Joomla which was really pro and has lots of features. Good luck and I hope you get the time and feel better to finish what u started.
 
View user's profile Send private message Visit poster's website
montego
Site Admin/Owner
Site Admin/Owner



Joined: Feb 12, 2005
Posts: 1393

PostPosted: Wed Feb 23, 2011 9:11 pm Reply with quote

Well, hicux, can't say all this time has been spent working on it. Wink Unfortunately, as projects go, it took a long time to pick it up and then when you've got only a couple of hours per week to code, one can't make too much progress unfortunately.

I might have to check out Joomla's offering.

_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins 
View user's profile Send private message Visit poster's website
Display posts from previous:       
Post new topic   Reply to topic

View next topic
View previous topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001-2007 phpBB Group
All times are GMT - 4 Hours
 
Forums ©
linear-bunchlinear-bunch