NSN Gr email issues

Newbie Joined: Jan 04, 2007 Posts: 61 Location: Germany

I found a problem with the e-mail adress within the messages from NSN GR Downloads.
Not sure if this is a bug or its my system but the e-mail address "from" doesn´t look right. Rolling Eyes

So quick question.
After a download is submitted there are 2 e-mail notifications.
Your submitted download has been approved! etc.

In wich file can I change in this e-mail my address ?

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1360

I'll have to get back to you on this one. I am not feeling so well and need to head to bed... Sad

Newbie Joined: Jan 04, 2007 Posts: 61 Location: Germany

Get well soon! Maybe I can find out more about the e-mail issue this weekend.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1360

Susann,
For Submit Downloads, the file is this one:

modules/Submit_Downloads/index.php

For the admin approving a new download, the mail is sent from here:

modules\Downloads\admin\DownloadAddSave.php

In each case, search for "mail(" and you will find where you need to make changes if you feel that you need to.

Newbie Joined: Jan 04, 2007 Posts: 61 Location: Germany

Thanks. I was able to change the e-mail in index.php.
But the importent changes in modules\Downloads\admin\DownloadAddSave.php
didn´t worked.
Montego how do I change my e-mail adress there ?
I don´t like the way its designed. The messages have the hostname as from in it and thats not the complete issue.
Btw: I added a download to your section to check how you e-mail looks like. Smile

Thats the part in DownloadAddSave.php :

Code:

$from = "$sitename";
@mail($email, $subject, $message, "From: $from\nX-Mailer: PHP/" . phpversion());
}

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1360

Ok, yeah, that is pretty ugly. Sad

Maybe this will get you by for now:

=== FIND CODE ===

Code:

if ($email!="") {
$subject = ""._YOURDOWNLOADAT." $sitename";
$message = ""._HELLO." $sname:\n\n"._DL_APPROVEDMSG."\n\n"._TITLE.": $title\n"._URL.": $url\n"._DESCRIPTION.": $description\n\n\n"._YOUCANBROWSEUS." $nukeurl/modules.php?name=$module_name\n\n"._THANKS4YOURSUBMISSION."\n\n$sitename "._TEAM."";
$from = "$sitename";
@mail($email, $subject, $message, "From: $from\nX-Mailer: PHP/" . phpversion());
}

=== REPLACE WITH ===

Code:

if ($email!="") {
$subject = ""._YOURDOWNLOADAT." $sitename";
$message = ""._HELLO." $sname:\n\n"._DL_APPROVEDMSG."\n\n"._TITLE.": $title\n"._URL.": $url\n"._DESCRIPTION.": $description\n\n\n"._YOUCANBROWSEUS." $nukeurl/modules.php?name=$module_name\n\n"._THANKS4YOURSUBMISSION."\n\n$sitename "._TEAM."";
$mailheaders = "From: $adminmail\r\n";
$mailheaders .= "Reply-To: $adminmail\r\n";
$mailheaders .= "X-Mailer: NSNGD\r\n";
@mail($email, $subject, $message, $mailheaders);
}

That might get you closer.

Newbie Joined: Jan 04, 2007 Posts: 61 Location: Germany

Great Montego this is solved !!!
Thank you so much !
I´m so glad that I got rid of these strange e-mail adresses. Smile

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1360

You are welcome. I, of course, when I get to it, incorporate these changes into a 1.1.0 release.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1360

Fixed in 1.1.0 currently in development when I added TegoNuke(tm) Mailer integration.

Newbie Joined: Jan 30, 2009 Posts: 52 Location: NL

Montego, when I see you working on this module step by step trying to make it perfect, secure and smooth I do not want to get rid of phpnuke but why it took so much time to make a more efficient download module who really does all like the one I had for Joomla which was really pro and has lots of features. Good luck and I hope you get the time and feel better to finish what u started.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1360

Well, hicux, can't say all this time has been spent working on it. Wink

Unfortunately, as projects go, it took a long time to pick it up and then when you've got only a couple of hours per week to code, one can't make too much progress unfortunately.

I might have to check out Joomla's offering.